Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cantera adapters expect T /P to be scalars and crash if they are lists #77

Open
alongd opened this issue Mar 13, 2022 · 0 comments
Open

Comments

@alongd
Copy link
Member

alongd commented Mar 13, 2022

RMG reactors accept T / P both as floats and as lists, but the Cantera adapters send these values w/o modification to Cantera as a (T0, P0, X0) tuple. If T / P are indeed lists, T3/Cantera crash.
Need to fix the adapters to allow T / P in a reactor to be a list.

Would we like to take the average value of the list? Or iterate through it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant