Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying species concentration range #48

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Allow specifying species concentration range #48

wants to merge 10 commits into from

Conversation

alongd
Copy link
Member

@alongd alongd commented Jul 27, 2020

Added an option to specify a concentration range to a species.

fixes #33

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020 •
edited

Codecov Report

Merging #48 into master will decrease coverage by 0.04%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   73.95%   73.91%   -0.05%     
==========================================
  Files           9        9              
  Lines        1478     1491      +13     
  Branches      378      381       +3     
==========================================
+ Hits         1093     1102       +9     
- Misses        253      255       +2     
- Partials      132      134       +2
Impacted Files Coverage Δ
t3/schema.py 74.10% <55.55%> (-0.58%) ⬇️
t3/main.py 71.63% <100.00%> (ø)
t3/utils/generator.py 87.17% <100.00%> (+1.06%) ⬆️
t3/utils/writer.py 85.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652029d...4d6555c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2020

This pull request introduces 1 alert when merging f340b5a into 652029d - view on LGTM.com

new alerts:

  • 1 for Unused import

@alongd alongd force-pushed the c_range branch 3 times, most recently from 874e292 to 4d6555c Compare July 27, 2020 02:30
@alongd
Copy link
Member Author

alongd commented Jul 27, 2020

RMG doesn't run as expected with ranged reactors when using a liquidReactor.
This branch should be tested for a simpleReactor, then perhaps remove the option to have a ranged reactor in combination with liquid phase.

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2020

This pull request introduces 1 alert when merging 4d6555c into 652029d - view on LGTM.com

new alerts:

  • 1 for Unused import

@codecov-io
Copy link

codecov-io commented Jan 4, 2021 •
edited

Codecov Report

Merging #48 (a8d34a3) into master (c93ccff) will decrease coverage by 0.58%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   74.61%   74.03%   -0.59%     
==========================================
  Files           9        9              
  Lines        1501     1521      +20     
  Branches      385      391       +6     
==========================================
+ Hits         1120     1126       +6     
- Misses        242      255      +13     
- Partials      139      140       +1
Impacted Files Coverage Δ
t3/schema.py 74.63% <86.36%> (+0.72%) ⬆️
t3/main.py 73.16% <100.00%> (ø)
t3/utils/writer.py 79.45% <100.00%> (-6.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93ccff...a8d34a3. Read the comment docs.

@alongd alongd force-pushed the c_range branch 10 times, most recently from 2a9e663 to 2e2bae3 Compare January 7, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples Module main Module schema Module writer tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Species should have a concentration_range attribute
3 participants
@alongd @codecov-commenter @codecov-io