Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Should have an option to calc thermo of all species accesible in a flux diagram at a certain tolerance #20

Open
alongd opened this issue Apr 30, 2020 · 2 comments

Comments

@alongd
Copy link
Member

alongd commented Apr 30, 2020

In addition to species selection by SA, we should also select by flux. E.g., generate a flux diagram at a requested tolerance and add all the included species to the calc list.

@alongd
Copy link
Member Author

alongd commented May 5, 2020

Another note to ourselves re species selection: should calculate thermo for all species participating in very exothermic/endothermic reactions in the core (very exothermic reactions could be a false flux sink)

@xiaoruiDong
Copy link

xiaoruiDong commented May 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants