Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-correct RMG termination criterion #124

Open
alongd opened this issue May 13, 2023 · 0 comments
Open

Auto-correct RMG termination criterion #124

alongd opened this issue May 13, 2023 · 0 comments

Comments

@alongd
Copy link
Member

alongd commented May 13, 2023

I ran a model generation with T3 with the following RMG termination criteria:

      termination_rate_ratio: 0.001
      termination_time: [60, 's']

RMG terminated once it reached the termination_rate_ratio:
At time 2.7169e-10 s, reached target termination RateRatio: 0.0009957255199092255

This is obviously not the intended behavior, since RMG terminated after less than a simulated time of a nano second only

We could add a minimal termination time to T3, and if some criterion causes it to terminate prematurely, T3 should modify that criterion and re-run RMG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant