Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations of CIR to resolve certain CAS numbers #258

Open
jonwzheng opened this issue Jun 29, 2023 · 0 comments
Open

Limitations of CIR to resolve certain CAS numbers #258

jonwzheng opened this issue Jun 29, 2023 · 0 comments

Comments

@jonwzheng
Copy link
Contributor

Issue

Sometimes the CIR is unable to resolve CAS numbers. This may limit the use of the RMG website if a user is unable to find the adjacency list using CAS number as a search.

Reproduce this

Go to the RMG molecule search (https://rmg.mit.edu/molecule_search) and search for 16940-81-1. You will see that the CIR is unable to resolve the CAS number, but if you instead search on CAS Common Chemistry (https://commonchemistry.cas.org/results?q=16940-81-1) the CAS number can be found.

Proposed fix / Todo

Implement a screener that detects whether the user input is in the form of a CAS number, and if so, search using the CAS Common Chemistry API instead of CIR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant