Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermo groups regression test #558

Open
davidfarinajr opened this issue Jan 12, 2022 · 0 comments
Open

Thermo groups regression test #558

davidfarinajr opened this issue Jan 12, 2022 · 0 comments

Comments

@davidfarinajr
Copy link
Contributor

Adding and/or modifying thermo groups in the database can have unintended consequences for molecules outside a training or test set. This problem often arises with "supergroups" (groups that include neighborhood dimensions > 1) and "double counting" a particular chemical moiety included in supergroups. Making an RMG regression test that compares RMG thermo library values vs GAV estimates (and flags molecules where GAV predictions are worse with PR compared to library values) could help identity these problems in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants