Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3MechV3.3 #557

Open
alongd opened this issue Jan 10, 2022 · 8 comments
Open

C3MechV3.3 #557

alongd opened this issue Jan 10, 2022 · 8 comments

Comments

@alongd
Copy link
Member

alongd commented Jan 10, 2022

I think we should make a library for C3MechV3.3 (surrogate fuels):
https://doi.org/10.1016/j.jaecs.2021.100043

@mefuller
Copy link
Member

mefuller commented Jan 10, 2022

convert_log.txt
Principally, I would agree. Is there anyone in the C3 consortium who would be a preferred point of contact when ambiguities arise?
In converting the mechanism from CK to YAML, I already found that there are thousands of duplicate thermo entries - I don't know how many are just identical and how many are conflicts (see attached).

@alongd
Copy link
Member Author

alongd commented Jan 10, 2022

I think we should use Richard's merger tool

Edit: importer tool

@mefuller
Copy link
Member

@alongd remind me, is that tool published on the website somewhere or is that the branch you pointed me to a while ago that was abandoned a few years back?

@alongd
Copy link
Member Author

alongd commented Jan 14, 2022

It's a branch on RMG-Py with a corresponding RMG-database branch.
The installation might be a bit tricky, I think I can help with that

Regarding the duplicate entries you pointed out - are they also duplicate in the original Chemkin mechanism?

@mefuller
Copy link
Member

Yes, I would appreciate some help with the installation - I don't think I'm familiar yet with the tool to which you're referring.

And yes, the input thermo file in Chemkin format contains those thousand of duplicates - that's what the log is showing: the comparison of the declared species against the thermo entries and then producing output for repeated thermo entries and also thermo entries for which the species was not declared (unneeded entries which are skipped for writing into the Cantera mechanism).

@rwest
Copy link
Member

rwest commented Feb 3, 2022

I have only just spotted this Issue - just as I was preparing to post about https://fuelmech.org/press/c3-releases-first-of-its-kind-detailed-chemical-kinetic-mechanism-for-surrogate-fuels in the RMG slack channel I thought I'd search the issue board. (If you want to catch my attention here then tag me @rwest!)
Happy to help with the importer.

@mefuller
Copy link
Member

mefuller commented Feb 3, 2022

@rwest @alongd I already contacted Henry Curran: there's a lot of duplicate/multiple thermo entries. He should be working to check that and fix the thermo portion before we fully import the mechanism.

The species and kinetics, however, look ok from using the ck2yaml coverter, so one could start on the dictionary development.

@alongd
Copy link
Member Author

alongd commented Apr 3, 2022

Recently communicated to @mefuller by Kelly Senecal:

The C3MechV3.3.THERM file dated December 21, 2021 contained duplicate species entries. This file has been updated to remove the duplicate entries. Results obtained using the original file should not have been affected. However, we recommend re-downloading C3MechV3.3 to obtain the clean C3MechV3.3.THERM file to use going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants