Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph and equivalent() is wrong and confusing #30

Closed
rwest opened this issue Apr 2, 2010 · 1 comment
Closed

Subgraph and equivalent() is wrong and confusing #30

rwest opened this issue Apr 2, 2010 · 1 comment

Comments

@rwest
Copy link
Member

rwest commented Apr 2, 2010

Currently the equivalent() methods match for
[Cd,Cs].equivalent([Cd,Cb,H]) = True
[Cd,Cb,H].equivalent([Cd,Cs]) = True
[R].equivalent([Cs]) = True
[Cs].equivalent([R]) = True
etc.
and the subgraph matching is confusingly named too.

I propose methods called self.isSpecificCaseOf(other) that is true if they are identical or self is fully contained within other (other is equal to or more general than self).

We may also need exact matching, such as self.isIdenticalTo(other) that is true only if they match exactly.

@rwest
Copy link
Member Author

rwest commented Jun 11, 2011

I think we now use isSpecificCaseOf() rather than (or in addition to??) equivalent() so I'm closing this issue. (although perhaps equivalent should become isIdenticalTo() for further clarity

@rwest rwest closed this as completed Jun 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant