Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo at RMG User's Guide #2165

Open
Jakubanoo opened this issue Jun 24, 2021 · 3 comments
Open

Typo at RMG User's Guide #2165

Jakubanoo opened this issue Jun 24, 2021 · 3 comments
Labels
bug bug which will never be closed by the actions bot Good First Issue

Comments

@Jakubanoo
Copy link

Bug Description

There is a wrong input at Example Input Files at RMG User's Guide (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/examples.html?)

How To Reproduce

It says:

    # overrides RMG transport calculations with these values.
    # if species exist in multiple libraries, the earlier libraries overwrite the previous values
    transportLibraries=['PrimaryTransportLibrary.py'],

the .py should not be there for this to work, so instead it should say:

    # overrides RMG transport calculations with these values.
    # if species exist in multiple libraries, the earlier libraries overwrite the previous values
    transportLibraries=['PrimaryTransportLibrary'],
@rwest
Copy link
Member

rwest commented Jul 27, 2021

Thanks for reporting this!

Here's where to fix it, if anyone wants a good first pull request
https://github.com/ReactionMechanismGenerator/RMG-Py/edit/master/examples/rmg/commented/input.py#L22

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 22, 2023
@JacksonBurns
Copy link
Contributor

This constitutes a bug but is easy to fix.

@JacksonBurns JacksonBurns added bug bug which will never be closed by the actions bot and removed stale stale issue/PR as determined by actions bot labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug which will never be closed by the actions bot Good First Issue
Projects
None yet
Development

No branches or pull requests

3 participants