Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely identical duplicate reactions in RMG mechanism #1873

Closed
cgrambow opened this issue Jan 21, 2020 · 5 comments
Closed

Completely identical duplicate reactions in RMG mechanism #1873

cgrambow opened this issue Jan 21, 2020 · 5 comments
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Topic: Duplicate Reactions

Comments

@cgrambow
Copy link

Bug Description

RMG-generated mechanisms contain seemingly identical duplicate reactions. The following is just one example found in the Chemkin file:

! Reaction index: Chemkin #38; RMG #623
! Template reaction: R_Addition_MultipleBond
! Flux pairs: C4H8(90), C4H9(76); H(3), C4H9(76); 
! From training reaction 10 used for Cds-CsH_Cds-HH;HJ
! Exact match found for rate rule [Cds-CsH_Cds-HH;HJ]
! Euclidian distance = 0
! family: R_Addition_MultipleBond
H(3)+C4H8(90)=C4H9(76)                              3.010000e+08 1.600     2.400    
DUPLICATE

! Reaction index: Chemkin #40; RMG #1911
! Template reaction: R_Addition_MultipleBond
! Flux pairs: H(3), C4H9(76); C4H8(90), C4H9(76); 
! From training reaction 10 used for Cds-CsH_Cds-HH;HJ
! Exact match found for rate rule [Cds-CsH_Cds-HH;HJ]
! Euclidian distance = 0
! family: R_Addition_MultipleBond
H(3)+C4H8(90)=C4H9(76)                              3.010000e+08 1.600     2.400    
DUPLICATE

Since it's the same exact match, I wouldn't expect the reaction to appear twice in the mechanism.

RMG version information:

  • RMG-Py: 3.0.0-2-g957ee80ad
  • RMG-database: 3.0.0-12-ga6deb396
@alongd
Copy link
Member

alongd commented Jan 22, 2020

related to #1336 and #1823

@cgrambow
Copy link
Author

In my mechanism with 3554 reactions, 76 reactions seem to be exact duplicates of each other with exactly the same kinetics. So I think this problem is quite significant because many reaction rates will be artificially increased.

@rwest
Copy link
Member

rwest commented Feb 5, 2020

Pull request #1856 addresses some duplicate issues. Maybe someone would like to review (and possibly merge) it, before investigating remaining duplicate problems.

@rwest
Copy link
Member

rwest commented Feb 5, 2020

See my last comment on #1856 however:

Note that although I think this fixes a problem that we had in identifying the duplicate reactions and labeling them as such for valid chemkin files, it does not address the question as to why we were making two such reactions in the first place. That might require more investigation.

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 21, 2023
@github-actions github-actions bot added the abandoned abandoned issue/PR as determined by actions bot label Jul 22, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned abandoned issue/PR as determined by actions bot stale stale issue/PR as determined by actions bot Topic: Duplicate Reactions
Projects
None yet
Development

No branches or pull requests

3 participants