Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fame uses fixed grain size(?) #289

Open
shamelmerchant opened this issue Oct 28, 2013 · 2 comments
Open

Fame uses fixed grain size(?) #289

shamelmerchant opened this issue Oct 28, 2013 · 2 comments

Comments

@shamelmerchant
Copy link
Contributor

I am wondering why we have fixed grain size when we write the fame input file

input.append("GrainSize J/mol 4184");

in https://github.com/GreenGroup/RMG-Java/blob/master/source/RMG/jing/rxn/FastMasterEqn.java

even though we calculate the grain size before writing the input

double grainSize = getGrainSize(grainMinEnergy, grainMaxEnergy,
            pdn.getNumUniIsomers()); // [=] kJ/mol 
@rwest
Copy link
Member

rwest commented Oct 28, 2013

Um, it does look like a mistake.
Introduced in 815a5ed, before we had the ability to change it.
It may not be as bad as it first sounds, as I think FAME will read both the number of grains and the grain size specification, and use whichever gives the smaller grains (most accurate result).
It does mean the current implementation will not let you use grains larger than 1kcal, but at least the whole "increase number of grains and try again" thing should be working.

@shamelmerchant
Copy link
Contributor Author

Okay, the reason I stumbled upon this is because I have a network which is failing with a negative steady state concentration error and wanted to specify a grain size of 0.5 kcal/mol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants