Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Other" group additivity thermo corrections not applied #285

Open
jwallen opened this issue Jan 15, 2013 · 0 comments
Open

"Other" group additivity thermo corrections not applied #285

jwallen opened this issue Jan 15, 2013 · 0 comments

Comments

@jwallen
Copy link
Contributor

jwallen commented Jan 15, 2013

One difference we've found between the RMG-Java and RMG-Py group additivity thermo estimates is that RMG-Java does not appear to apply corrections from the "other" groups, while RMG-Py does. An example is 1,2-dimethylbenzene, for which RMG-Py adds two corrections for "ortho" groups. (Depending on how the correction values were determined, this could be an incorrect double-counting, but that's a separate question.) Looking at the code, it seems this has been the case since at least February of 2009, and probably before that.

The "other" groups currently contains corrections for cis double bonds, ketenes, and the ortho group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant