Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] AttributeError: module 'scipy.stats' has no attribute 'gibrat' #91

Open
calvinp0 opened this issue Jul 28, 2023 · 2 comments

Comments

@calvinp0
Copy link
Member

calvinp0 commented Jul 28, 2023

Describe the bug

The package 'descriptastorus' has had a recent fix in the naming convention for the attribute 'gibrat' - https://github.com/bp-kelley/descriptastorus/blob/86eedc60546abe6f59cdbcb12025a61157ba178d/descriptastorus/descriptors/dists.py#L207C1-L207C1 as in scipy they used to refer it to gilbrat but have since fixed it to be gibrat (notice the removal of the l). This is not reflected n the git repository but there was an upload of a new version, 2.6.0, in the conda-forge channel: https://anaconda.org/conda-forge/descriptastorus. And so, the fix up is included in this version

However, since AutoTST is kept to python 3.7.* (I believe due to RMG), it installs an older version of scipy (1.7.3), whereas descriptastorus is expecting scipy>=1.9.0. and therefore, the older version still maintains the attribute naming convention as gilbrat

@calvinp0
Copy link
Member Author

calvinp0 commented Jul 28, 2023

My current fix is adjusting the environment.yml file:

name: tst_env
channels:
  - defaults
  - cantera
  - pytorch
  - anaconda
  - conda-forge
dependencies:
  - python
  - rmg::rmg
  - conda-forge::ase
  - conda-forge::cclib >= 1.7.0
  - conda-forge::py3dmol
  - rmg::rdkit >= 2019.03.4
  - codecov
  - nose
  - matplotlib
  - pip:
    - git+https://github.com/bp-kelley/descriptastorus

This is unstainable due to the fact the author of the repo for descriptastorus will be merging the update at some point

@calvinp0
Copy link
Member Author

We can also do something like this:

name: tst_env
channels:
  - defaults
  - cantera
  - pytorch
  - anaconda
  - conda-forge
dependencies:
  - python
  - rmg::rmg
  - conda-forge::ase
  - conda-forge::cclib >= 1.7.0
  - conda-forge::py3dmol
  - rmg::rdkit>=2019.03.4
  - rmg::descriptastorus
  - codecov
  - nose
  - matplotlib

But the problem is we get stuck with descriptastorus 2.2.0 in the RMG Channel

@calvinp0 calvinp0 pinned this issue Jul 28, 2023
@calvinp0 calvinp0 unpinned this issue Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant