Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit tests for autotst/data/update.py #45

Open
nateharms opened this issue Oct 22, 2019 · 0 comments
Open

Missing unit tests for autotst/data/update.py #45

nateharms opened this issue Oct 22, 2019 · 0 comments

Comments

@nateharms
Copy link

Unit tests currently exist but are very sparse right now for the update methods. This was caught in PR #43 but will be addressed within this issue
nateharms pushed a commit that referenced this issue Oct 22, 2019
Merge pull request #43 from ReactionMechanismGenerator/py3
73ec0f3 
The tests are passing with krsna's Openbabel 2.4.1a and ampayne's RMG 3.0.0b. 🎉 Coverage is down a touch (1.11%) but this is because some of our import shuffling - Addressing this coverage will be done in #45 but for now, we can merge this in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nateharms