Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few patches to the restart #621

Merged
merged 3 commits into from Mar 25, 2023
Merged

A few patches to the restart #621

merged 3 commits into from Mar 25, 2023

Conversation

alongd
Copy link
Member

@alongd alongd commented Mar 24, 2023

ARC's restart should be remade one day. Here are a few patches to avoid running undesired jobs when restarting ARC

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #621 (d90afa9) into main (5a9137f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   73.02%   73.03%           
=======================================
  Files          99       99           
  Lines       26176    26178    +2     
  Branches     5481     5482    +1     
=======================================
+ Hits        19116    19118    +2     
+ Misses       5699     5698    -1     
- Partials     1361     1362    +1     
Impacted Files Coverage Δ
arc/scheduler.py 20.18% <0.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alongd alongd requested a review from kfir4444 March 25, 2023 07:57
Copy link
Collaborator

@kfir4444 kfir4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! @alongd

@kfir4444 kfir4444 merged commit 1e992b0 into main Mar 25, 2023
6 of 7 checks passed
@kfir4444 kfir4444 deleted the restart branch March 25, 2023 20:10
@calvinp0 calvinp0 linked an issue Mar 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving KeyError: conformers when attempting to arcrestart
2 participants