Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit.py renamed to arc_submit.py #585

Closed

Conversation

Rishav1707
Copy link

This PR closes the following issue:

closes #584

Changes made:

  • Renamed submit.py to arc_submit.py file.

@kfir4444
Copy link
Collaborator

Thanks @Rishav1707,
however, this issue requires additional work, for example, changing the references for this file in the code.

@alongd
Copy link
Member

alongd commented Dec 26, 2022

Hi @Rishav1707, we're happy to see contributions from the community. But we also expect them to be comprehensive. The fix you suggested should include additional modifications in the actual code to correctly import this file after it is renamed. As the feature request suggests, the docs should also be updated appropriately. It's indeed a "good first issue", but I believe that its appropriate for users of this software who would like to contribute, since a bigger context is needed.

@alongd alongd closed this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should rename submit.py
3 participants