Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing of transforms is unclear and overengineered #242

Open
thejayps opened this issue Jun 14, 2023 · 1 comment · May be fixed by #252
Open

Testing of transforms is unclear and overengineered #242

thejayps opened this issue Jun 14, 2023 · 1 comment · May be fixed by #252
Labels
essential Will cause failure to meet customer requirements. Assign resources.

Comments

@thejayps
Copy link
Contributor

thejayps commented Jun 14, 2023 •
edited

Transforms test in ztfm.c (at the time of writing, in branch #214) lacks clear comments for most of the code, contains unused code, and contains a somewhat overengineered parser (which may be useful to develop elsewhere as part of test infrastructure). This, in addition to combining many test cases into one function, makes the file very long and difficult to understand and review.

We should re-design the testing of transforms.

Fixing this issue may provide a solution to #243
@thejayps thejayps mentioned this issue Jun 14, 2023
Open
@rptb1 rptb1 mentioned this issue Jun 14, 2023
Merged
rptb1 added a commit that referenced this issue Jun 16, 2023
@rptb1
Removing bogus test block introduced in d769826 that does not work wh…
0b27a6c 
…en transforms are empty or trivial. Raising this for later in GitHub issue #242.
@rptb1
Copy link
Member

rptb1 commented Jun 16, 2023

See also 0b27a6c

@rptb1 rptb1 linked a pull request Jun 17, 2023 that will close this issue
Open
@thejayps thejayps added the essential Will cause failure to meet customer requirements. Assign resources. label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
essential Will cause failure to meet customer requirements. Assign resources.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Experimental example abstract machine with exact GC Ravenbrook/mps
2 participants
@rptb1 @thejayps