Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Taxonomy support in Lumberjack #16

Open
joldnl opened this issue Mar 13, 2019 · 5 comments · May be fixed by Rareloop/lumberjack-core#13
Open

Custom Taxonomy support in Lumberjack #16

joldnl opened this issue Mar 13, 2019 · 5 comments · May be fixed by Rareloop/lumberjack-core#13

Comments

@joldnl
Copy link

joldnl commented Mar 13, 2019

Is there or will there be custom taxonomy support in Lumberjack? I haven't been able to register or use them at all in lumberjack, and there seems to be no documentation regarding this at all...

@adamtomat
Copy link
Member

Great question. As Lumberjack is just a layer on top of WordPress, you can register and use custom taxonomies the usual WordPress way.

Saying that it is something we are keen add into Lumberjack. We were thinking of a similar setup to custom post types. We have made a start in this already, but I can't say when it'll be finished.

It's also worth noting that due to Lumberjack's extensibility, you can write your own implementation. You could write your own service provider to register. This is Lumberjack's service provider for custom post types as a guide:

https://github.com/Rareloop/lumberjack-core/blob/master/src/Providers/CustomPostTypesServiceProvider.php

Any more questions please let me know.

@joldnl
Copy link
Author

joldnl commented Mar 14, 2019

Thanks for the great answer. I've managed to implement the registration of custom taxonomies the same way custom post types are registered. This still needs some work, but the basics are layed out at this point.

I'd love to see what you can come up with better and deeper support for taxonomies within lumberjack.

@adamtomat
Copy link
Member

Glad you managed to handle the registration yourself. We have some decisions to make, that involve understanding more about Timber's Term class more, as we'll probably want to extend this (similar to how we extend Timber's Post).

So yeah, this is on the cards but we want to make sure we get it right :)

@joldnl
Copy link
Author

joldnl commented Mar 4, 2020

Is there any news or progress on native custom taxonomy support in Lumberjack?

@cwahlfeldt
Copy link

+1. Just ran into the need for taxonomies. @joldnl would you mind sharing your implementation? Cheers!

@idflood idflood linked a pull request Oct 2, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants