Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide chapter timecodes in a popover #398

Open
nekohayo opened this issue Feb 26, 2024 · 3 comments
Open

Provide chapter timecodes in a popover #398

nekohayo opened this issue Feb 26, 2024 · 3 comments

Comments

@nekohayo
Copy link

Currently, in version 0.5.2, Clapper is able to display chapter titles names, but it only displays them while dragging, while the time slider is strictly aligned with one of the notch marks :

image

image

While the slider (or mouse cursor) is "between" the marks, it shows nothing. This makes it quite difficult to actually see those helpful popover tooltips.

Instead it should show that throughout the width of the slider as long as the mouse hovers it.

When chapter names are not just digits and punctuation (i.e. timecodes) but actually contain other types of characters, it should also show the timecodes below the chapter name. Something like:

Street Scene; Interrupted Sushi
00:07:26

Showing the timecodes there, would be a better (or complementary) visual solution to #14 for non-touch desktop mode users (though presumably, touch users would still be able to see the popovers while scrubbing/dragging).

@Rafostar
Copy link
Owner

Rafostar commented Feb 26, 2024

Instead it should show that throughout the width of the slider as long as the mouse hovers it.

This part is already done.

it should also show the timecodes below the chapter name

When combined anyplace hover + chapter start time, wouldn't it be confusing as popover would show start time of preceding mark and NOT the actual time cursor hovers upon? Also not sure if two lines of text in popover would not create an unnecessary clutter.

@nekohayo
Copy link
Author

When combined anyplace hover + chapter start time, wouldn't it be confusing as popover would show start time of preceding mark and NOT the actual time cursor hovers upon? Also not sure if two lines of text in popover would not create an unnecessary clutter.

Oh sorry I was unclear, I actually meant / expect this dynamically-moving popover to show the time "at the cursor position" (not the static time of the chapter's start mark), yes.

@Rafostar
Copy link
Owner

Rafostar commented Apr 6, 2024

In latest git, chapter names are shown on hover (or while dragging slider on touchscreen).

@Rafostar Rafostar changed the title Provide chapter names and timecodes in a popover throughout the time slider while hovering it at any position Provide chapter timecodes in a popover Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants