New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable software-amplification of volume by default #395
Comments
While I agree with the first, the second not so much. Software amplification changes waveform programically. It does not increase current in the amplifier. Worst case can be harmful for your ears.
This setting is for the desktop. App should not try to read and assume that if user set something elsewhere for another app (including desktop/gnome-shell), that this will affect some video player slider. Also it should be possible to have amplified video player only (without desktop).
First thing that player currently lacks is some sort of clear OSD indication that scale went above 100%. Especially when controls panel is hidden. |
But one question is left unanswered:
or if you don't agree with the above, then:
I think the 1st option is better. Take a note that even if OSD is implemented for volume change on scroll-wheel, I would not want video player to cross 100% of volume ever, hence those 2 questions above. |
As surprising as it is... this request here needs more careful design planning then probably you initially imagine. I am gonna take it as our upcoming API request/related stuff. Considering Clapper will have separate widgets that either change or show current volume level. Implementing what requested here is gonna need:
2nd one seems most problematic from the ease of use point. For now safest bet is probably to introduce new APIs without this functionality and we can always add this in the future once we reach a conclusion. Open for further discussion. |
I wonder if were possible to paint the volume level widgets red if the level is |
ah yes, thats what also imagined. I personally find it unnecessary to disable it by default it should be obvious that the audio quality will degrade in this case. |
Currently, maximum volume is at 150%.
Use 100% maximum volume by default & make software-amplification of volume the option in preferences.
Reason?
When user accidentally uses mouse scroll-wheel & increases the volume, he will notice this unpleasant experience.
Ideally, volume slider in Clapper would gather Gnomes schema related to that & dynamically enable/disable software-amplification of volume according to schema:
org.gnome.desktop.sound allow-volume-above-100-percent
But what about having this functionality in other DEs?
So I think that it's better to just make this an option & use 100% maximum volume by default.
The text was updated successfully, but these errors were encountered: