You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In AuctionBid.java:parseArgBid() ln 148
bidAmount = currentBid.getBidAmount() + auction.getMinBidIncrement();
This line can't gain needed validation of the user's request for max bid (currentBid + MinBidIncrement > MaxBid).
This leaves the validation of "if max bid is under requested 0 bid, don't bid" falls to parseArgMaxBid.
Currently, ln 171 pushes max bid to min bids amount. In the case of /bid 0 x, it shouldn't. Could this section either gain validation that max bid can't be less then bid amount, or a check of the args that a zero request was made?
I see '/bid 0 y' to mean "raise max bid to" not "auto bid always, then raise max bid to"
/bid x y can cause an over bid above what the user asked to bid.
Steps to replicate:
One players auctions:
/auc 64 100 1000 59
Second player bids:
/bid
A third player bids:
/bid 0 300
Player three then has a bid up for $1000, well over what they asked their max to be.
(/auc about and /auc ? doesn't state a version number.)
The text was updated successfully, but these errors were encountered: