Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read.FCS fails if transformation=custom keyword is present but flowCore_$PnRmax isn't present for all channels #230

Open
zbjornson opened this issue May 7, 2022 · 1 comment

Comments

@zbjornson
Copy link

flowCore/R/IO.R

Lines 1028 to 1031 in 4c4186d

if( "transformation" %in% names(x) && x[["transformation"]] == "custom"){
range_str <- sapply(seq_len(nrpar),function(k){
x[[sprintf("flowCore_$P%sRmax", k)]]
})

The above assumes that flowCore_$P%sRmax will be present for all parameters, but that's not necessarily the case. Many tools pass-through keywords from original FCS files while adding one or more new parameters. Could this be changed to fall back to $PnR?

@SamGG
Copy link
Contributor

SamGG commented May 7, 2022

Hi Zach,
I dislike flowCore transformation being encoded/annotated in FCS files. This creates problem as you encounter. I have already raised the same/similar issue (Why the flowCore_$P parameters are written to disk instead of using the standard $PR? #201). Does setting tranformation=FALSE pose a problem to your code? I only rely on that.
Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants