Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated timelines for pilot 3 resubmission. Closes #108 #111

Merged
merged 1 commit into from May 16, 2024

Conversation

laxamanaj
Copy link
Collaborator

Closes #108

@laxamanaj laxamanaj requested a review from rpodcast April 24, 2024 19:22
@laxamanaj
Copy link
Collaborator Author

Hi, @bms63 . When you have the chance feel free to pull #108 branch and comment here if update looks ok (I couldn't add you as a reviewer on this PR).

@rpodcast , once @bms63 confirms this looks ok, can you merge for us? Thanks in advance.

- For FDA Staff
- Reproduce analysis results by reproducing the R environment and retrieving both proprietary & open source packages
- For Submitter
- Generation of a reproducible R environment with a proprietary R package from git and open source R packages using `{renv}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the from git?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Generation of a reproducible R environment with a proprietary R package from git and open source R packages using `{renv}`
- Generation of a reproducible R environment installing open source R packages using `{renv}` and installing a proprietary R package following independent steps. In future, sponsor specific submissions, it is likely that sponsors may create their own internal proprietary R packages, which may not be publicly available. Thus, providing steps on how to submit and install a proprietary R package using independent steps allows others in the industry to follow the same approach. In this working group we've tested these proprietary R package submission and installation steps succesfully :
- Pilot 1 - {pkglite}
- Pilot 2 - {pkglite}
- Pilot 3 - Github
- Pilot 3 - Local install via .zip (Pending FDA feedback)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i like this!!

Copy link
Contributor

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm loving it

@laxamanaj laxamanaj merged commit 81d8d6e into main May 16, 2024
@laxamanaj laxamanaj deleted the 108-pilot3-resubmission branch May 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pilot 3 Timeline update
2 participants