Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled tests still run #934

Open
1 task done
abear247 opened this issue Nov 8, 2019 · 4 comments
Open
1 task done

Disabled tests still run #934

abear247 opened this issue Nov 8, 2019 · 4 comments
Labels

Comments

@abear247
Copy link

abear247 commented Nov 8, 2019

  • I have read CONTRIBUTING and have done my best to follow them.

What did you do?

Attempted to disable a Quick test. I also disabled an XCTest to ensure this was a Quick bug and not just Xcode.

What did you expect to happen?

I expected that the test file would not run

What actually happened instead?

All the disabled tests still ran on the disabled QuickSpec, but none of the tests ran on the disabled XCTest.

I am able to use xdescribe to disable this test for the time being, but ideally we should be able to disable tests in the scheme.

Environment

List the software versions you're using:

  • Quick: 2.2.0
  • Nimble: 8.0.1
  • Xcode Version: Version 11.2 (11B52)
  • Swift Version: `Xcode Default

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

  • Carthage: 0.33.0
@ikesyo
Copy link
Member

ikesyo commented Nov 10, 2019

I'm not sure what disabled tests do mean. Could you elaborate it? And also a minimal reproducible example would be a help.

@abear247
Copy link
Author

Example test suit, the disabled DisabledTests ran (QuickSpec), enabled tests EnabledTests ran (QuickSpec), and disabled XCExampleTests (XCTest) did not run.
Screen Shot 2019-11-11 at 9 42 12 AM

This screen shot shows the right click -> disable that I use to disable tests
Screen Shot 2019-11-11 at 9 42 19 AM

And here is a sample project
QuickExample.zip

@Shiaulis
Copy link

Shiaulis commented Dec 6, 2019

Migrating to test plans helped in my project. I can disable tests in a new test plan file now

@Ner1Co
Copy link

Ner1Co commented Jan 15, 2020

Is it related to #886?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants