Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary monkeypatch.chdir calls on tests #2134

Open
Andrew-S-Rosen opened this issue May 12, 2024 · 0 comments
Open

Remove unnecessary monkeypatch.chdir calls on tests #2134

Andrew-S-Rosen opened this issue May 12, 2024 · 0 comments
Labels
good-first-issue housekeeping Things to tidy up that are otherwise kind of boring tests

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented May 12, 2024

What would you like to report?

Now that we never write in the current working directory, we don't need to do monketpatch.chdir everywhere in the test suite. We should remove these unnecessary calls, although there will be a few required.

@Andrew-S-Rosen Andrew-S-Rosen added housekeeping Things to tidy up that are otherwise kind of boring tests labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue housekeeping Things to tidy up that are otherwise kind of boring tests
Development

Successfully merging a pull request may close this issue.

1 participant