Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MP2024 recipes #2138

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

Implement MP2024 recipes #2138

wants to merge 43 commits into from
+349 −376

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented May 13, 2024 •
edited

Summary of Changes

Implement the 2024 MP recipes. Closes #2019.

Requires:

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft May 13, 2024 04:27
@Andrew-S-Rosen Andrew-S-Rosen added the waiting-for-upstream Issue or PR is waiting for an upstream code change. label May 13, 2024
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (68fc1c3) to head (724104e).

Files Patch % Lines
src/quacc/schemas/vasp.py 82.35% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
- Coverage   99.01%   98.92%   -0.10%     
==========================================
  Files          81       81              
  Lines        3363     3359       -4     
==========================================
- Hits         3330     3323       -7     
- Misses         33       36       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
VASP waiting-for-upstream Issue or PR is waiting for an upstream code change.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the new MP 2024 workflows to VASP
1 participant
@Andrew-S-Rosen