Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy_files support with Parsl #1942

Merged
merged 19 commits into from
May 30, 2024
Merged

Fix copy_files support with Parsl #1942

merged 19 commits into from
May 30, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Mar 25, 2024

Summary of Changes

Closes #1776.

Requires:

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft March 25, 2024 19:06
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review March 25, 2024 20:33
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (0a1ec93) to head (f10c912).

Current head f10c912 differs from pull request most recent head 6cd9fac

Please upload reports for the commit 6cd9fac to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
+ Coverage   99.04%   99.06%   +0.02%     
==========================================
  Files          81       81              
  Lines        3357     3323      -34     
==========================================
- Hits         3325     3292      -33     
+ Misses         32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft April 11, 2024 22:29
@Andrew-S-Rosen Andrew-S-Rosen added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 22, 2024
@Andrew-S-Rosen Andrew-S-Rosen added the waiting-for-upstream Issue or PR is waiting for an upstream code change. label May 13, 2024
@Andrew-S-Rosen Andrew-S-Rosen removed the waiting-for-upstream Issue or PR is waiting for an upstream code change. label May 30, 2024
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review May 30, 2024 23:20
@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) May 30, 2024 23:20
@Andrew-S-Rosen Andrew-S-Rosen merged commit dcbb582 into main May 30, 2024
16 of 17 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the parslfix branch May 30, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

The copy_files keyword can fail when using the output directory from a prior @job with Parsl
1 participant