Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all with pytest.raises() checks in the test suite have an associated match #1708

Open
Andrew-S-Rosen opened this issue Feb 15, 2024 · 0 comments
Open

Ensure all with pytest.raises() checks in the test suite have an associated match #1708

Andrew-S-Rosen opened this issue Feb 15, 2024 · 0 comments
Labels
good-first-issue tests

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Feb 15, 2024 •
edited

What would you like to report?

We want to make sure we catch a specific exception. When done, the following lines in pyproject.toml should be removed:

quacc/pyproject.toml

Lines 161 to 163 in d95ca63

"B017", # pytest.raises
"PT011", # pytest.raises
"PT012", # pytest.raises

@Andrew-S-Rosen Andrew-S-Rosen mentioned this issue Feb 15, 2024
Merged
Andrew-S-Rosen added a commit that referenced this issue Feb 15, 2024
@Andrew-S-Rosen
Stricter matches on raised errors in test suite (#1707)
f5d43ed 
Closes #1700.

Partially addresses #1708.
@Andrew-S-Rosen Andrew-S-Rosen changed the title Ensure all with pytest.raises() checks in the test suite have an associated reason Ensure all with pytest.raises() checks in the test suite have an associated match Feb 18, 2024
@Andrew-S-Rosen Andrew-S-Rosen mentioned this issue Mar 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue tests
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andrew-S-Rosen