Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily run failure: Unit tests #784

Closed
github-actions bot opened this issue Apr 6, 2024 · 6 comments
Closed

Daily run failure: Unit tests #784

github-actions bot opened this issue Apr 6, 2024 · 6 comments
Assignees

Comments

@github-actions
Copy link

github-actions bot commented Apr 6, 2024

The daily unit tests failed. See https://github.com/Quantco/glum/actions/runs/8578861406 for details.

@stanmart
Copy link
Collaborator

stanmart commented Apr 6, 2024

I believe the reason for the nightly failure is this deprecation came into effect in pandas 3.0.0dev0:

@MatthiasSchmidtblaicherQC
Copy link
Contributor

I think I managed to reproduce it:

import pandas as pd

pd.SparseDtype(bool, fill_value=0)

after installing the nightly version of pandas raises ValueError: fill_value must be a valid value for the SparseDtype.subtype. See also changes to test_array here. So fill_value in https://github.com/Quantco/tabmat/blob/0e22f477e134cf119789eab8279f5abf2b5b193a/src/tabmat/constructor.py#L111 should be changed to False for Booleans.

@stanmart
Copy link
Collaborator

@MatthiasSchmidtblaicherQC now that your PR is merged this can be closed, right?

@lbittarello
Copy link
Member

The daily tests are still failing, but for different reasons: https://github.com/Quantco/glum/actions/runs/9153751283/job/25163209834

@stanmart
Copy link
Collaborator

stanmart commented May 21, 2024

Oh I see. #792 should fix the test_formula failures. The rest are due to scipy removing the .A shorthand for toarray(), and need to be fixed in tabmat.

@MarcAntoineSchmidtQC
Copy link
Member

fixed with tabmat #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants