Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidate Returns a List of Order IDs With Any Status #7839

Open
4 tasks done
AlexCatarino opened this issue Mar 8, 2024 · 0 comments
Open
4 tasks done

Liquidate Returns a List of Order IDs With Any Status #7839

AlexCatarino opened this issue Mar 8, 2024 · 0 comments

Comments

@AlexCatarino
Copy link
Member

Expected Behavior

Liquidate method returns a list of order ticket IDs with any status.

Actual Behavior

Only returns IDs of filled orders.

Potential Solution

Remove ticket.Status == OrderStatus.Filled condition.

For consistency with other trading and orders methods, Liquidate should return a list of OrderTicket.

public List<OrderTicket> Liquidate(Symbol symbolToLiquidate = null, string tag = "Liquidated")

See also #6818

Reproducing the Problem

Call Liquidate for daily data. It will create MOO orders, ticket.Status == OrderStatus.Filled is false and the returned list is empty.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant