Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aotraits code style improvement #4840

Open
PDoakORNL opened this issue Nov 20, 2023 · 1 comment
Open

aotraits code style improvement #4840

PDoakORNL opened this issue Nov 20, 2023 · 1 comment
Assignees
@PDoakORNL

Comments

@PDoakORNL
Copy link
Contributor

Uses magic numbers that should be enum classes.
violates naming conventions
inconsistent documentation and most documentation in implementation file not header.

enums for non type parameters of AOTraits.
@prckent
Copy link
Contributor

prckent commented Nov 20, 2023

Please can you assign this issue. Not sure if this is a a note to yourself or someone else.

@PDoakORNL PDoakORNL self-assigned this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PDoakORNL PDoakORNL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PDoakORNL @prckent