Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing of splined Jastrows near cutoffs distances needed #4830

Open
prckent opened this issue Nov 10, 2023 · 0 comments
Open

Unit testing of splined Jastrows near cutoffs distances needed #4830

prckent opened this issue Nov 10, 2023 · 0 comments

Comments

@prckent
Copy link
Contributor

prckent commented Nov 10, 2023

Following the discussion in #4828 , better unit tests are needed for the Jastrow functions that use splines. e.g. Testing just before, at, after the cutoff values. Unit test level is needed so that sanitizer runs will catch invalid accesses. Should entail only a few extra evaluations in the existing unit tests. Not testing here led to us missing an out of bounds issue in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant