Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit a comment #161

Open
yammesicka opened this issue Sep 20, 2020 · 1 comment · Fixed by #225
Open

Allow to edit a comment #161

yammesicka opened this issue Sep 20, 2020 · 1 comment · Fixed by #225

Comments

@yammesicka
Copy link
Member

We should NOT change the CommentText itself.
This is a mutable behavior we prefer to avoid whenever we can, and may mistakenly change previous comments of the author.

Instead, we should check if the new text is already in CommentText.
If it is exist in CommentText, we update Comment so it would refer to the CommentText foreign key.
If not, we should create a new CommentText.

@Gonzom
Copy link

Gonzom commented Sep 24, 2020

I'll take this one 👍

@orronai orronai linked a pull request Oct 5, 2020 that will close this issue
@yammesicka yammesicka reopened this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants