Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom icons instead of the material icons #12

Open
Wndworks opened this issue Oct 3, 2017 · 9 comments
Open

Use custom icons instead of the material icons #12

Wndworks opened this issue Oct 3, 2017 · 9 comments

Comments

@Wndworks
Copy link

Wndworks commented Oct 3, 2017

Hi,

Nice plugin. I've a request. Can you make it possible to use also custom icons? That would be awesome.

Looking forward for your reply.

@hazzo
Copy link
Contributor

hazzo commented Oct 3, 2017

Hi @Wndworks, yes could do be done. But if we leave it very customizable devs will have to handle some styling by their own.
You are thinking on adding custom HTML for example? Or classes with pseudo elements like before and after to handle content by css?

@Wndworks
Copy link
Author

Wndworks commented Oct 3, 2017

Hi @hazzo,

Thanks for the fast reply.
I'm already using another FAB component, but i thought about adding custom html indeed. Like:

<i class="icon-class"></i>

In this case any icon font can be used.

@hazzo
Copy link
Contributor

hazzo commented Oct 4, 2017

Okey as soon as it's implemented I'll update this issue

@Wndworks
Copy link
Author

Wndworks commented Oct 4, 2017

Thank you!

@ymhuang0808
Copy link

ymhuang0808 commented Apr 16, 2018

I'm trying to implement to support custom icons. I found if vue-fab allows to customize the icons by HTML, it should handle the toggle variable for main icon.

For example:

vue-fab/src/FAB.vue

Lines 48 to 49 in e7ff12d

<i :class="[ mainIconSize , { rotate: toggle }, 'material-icons main']">{{mainIcon}}</i>
<i :class="[ mainIconSize , { rotate: toggle }, 'material-icons close']">add</i>

It looks like it also parses the class names in HTML and sets { rotate: toggle } in class. Is there a better way to implement?

@50l3r
Copy link

50l3r commented Apr 29, 2018

+1

2 similar comments
@mihaisaru
Copy link

+1

@ndro
Copy link

ndro commented Aug 31, 2018

+1

@igorjacauna
Copy link

Exists a PR open #20 any chance to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants