Fixing energy totals rescale function #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toniseibold watch out the warning regarding the assignment of values after a Instead of you should probably go for |
|
Thanks @FabianHofmann - missed that one. |
|
I had to make some changes, but they were difficult to trace, so no worries! The "total" includes electricity for the transport sector, so the entries with "electricity" shouldn't be included in the sum. The mismatch in the totals seemed to come from the missing entry "total heavy duty road freight" in the rescaling. |
fneum
added a commit
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Closes #985.
Bug fix in the function
rescale_idees_from_eurostat():So far, the sum of agriculture and transport did not add up to
total agricultureandtotal transportsince there are two different rescaling factors forelectricityandtotal.@lindnemi: the sectors
residentialandservicesis not adding up since it's taking data from JRC IDEES from multiple sheets.Minor changes so no change in the environment, configuration and release notes.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.