Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What all should I solve in a Pull Request? #47

Open
theSage21 opened this issue Jan 20, 2019 · 0 comments
Open

What all should I solve in a Pull Request? #47

theSage21 opened this issue Jan 20, 2019 · 0 comments
Labels
Discussion/Doubts/Tutorial A discussion to understand some topic

Comments

@theSage21
Copy link
Member

Sometimes it can be difficult to know what all to solve. Multiple issues can be related to each other and sometimes solving one thing can cause other issues and so on. Here are a few guiding principles. They can be broken, but only if a very good reason is there.

A good reason can be "This PR will fix 100 issues together with 1 line of code".

  • fix only one issue in a PR
  • If many issues are related, submit multiple PRs
  • Try to fill out the PR template to the best of your ability
  • If you know this is a work in progress and are not ready for review yet, use WIP: in the title.

There are other guidelines but they only come into picture once the project is large enough. For now this should be ok.
@theSage21 theSage21 added the Discussion/Doubts/Tutorial A discussion to understand some topic label Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion/Doubts/Tutorial A discussion to understand some topic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theSage21