Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: on Chromium and Firefox, TaskAssigner dropdown shows up at top of screen #161

Open
elimisteve opened this issue Apr 20, 2018 · 2 comments
Assignees
Milestone

Comments

@elimisteve
Copy link
Contributor

No description provided.

@elimisteve
Copy link
Contributor Author

@Moe-Shoman figured out that this sort of thing is key to the fix:

diff --git a/src/utils/suggestions.js b/src/utils/suggestions.js
index 33ade5b..ab11671 100644
--- a/src/utils/suggestions.js
+++ b/src/utils/suggestions.js
@@ -13,7 +13,8 @@ const sortBySuggest = (suggest1, suggest2) => {
   return suggest1.suggestionName.localeCompare(suggest2.suggestionName);
 };

-export const scrollIntoViewOptions = { behavior: 'instant', block: 'nearest' };
+export const scrollIntoViewOptions = { behavior: 'smooth', block: 'nearest' };
 if (window.browser === 'Firefox') {
-  delete scrollIntoViewOptions.block;
+  // delete scrollIntoViewOptions.block;
+  scrollIntoViewOptions.block = 'end';

@elimisteve
Copy link
Contributor Author

elimisteve commented Jul 12, 2018

Possible solution, from @Moe-Shoman:

-export const scrollIntoViewOptions = { behavior: 'instant', block: 'nearest' };
+export const scrollIntoViewOptions = { behavior: 'smooth', block: 'nearest' };

EDIT: This change fixes the behavior in Chromium and Firefox, but breaks it within Chrome.

That is:

  • Firefox needs behavior: 'smooth'
  • Chromium also needs behavior: 'smooth'
  • Chrome needs behavior: 'instant'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants