Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: nested writes are not allowed #231

Open
yrashk opened this issue Apr 7, 2017 · 0 comments
Open

Problem: nested writes are not allowed #231

yrashk opened this issue Apr 7, 2017 · 0 comments
Labels
PumpkinScript Storage

Comments

@yrashk
Copy link
Contributor

yrashk commented Apr 7, 2017

Currently we prohibit nested writes (#230) because they don't make sense until we support lmdb's child transactions

Proposed solution: add support for lmdb's child transactions.
@yrashk yrashk mentioned this issue Apr 17, 2017
Closed
yrashk added a commit to yrashk/PumpkinDB that referenced this issue Jun 26, 2017
@yrashk
Problem: nested comments don't get parsed right
1cc0672 
```
PumpkinDB> ((Hello)).
Script error: Superfluous([41])
```

Solution: allow comment parser to go recursively

It is important to mention that the parser will not work
well with unbalanced parens. Therefore, nested comments
should always be correct. This requirement might be removed
in the future to enable fully free-form comments.

Fixes PumpkinDB#231
@yrashk yrashk mentioned this issue Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PumpkinScript Storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yrashk