Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Tag filter doesn't work #1977

Closed
2 tasks done
evie-lau opened this issue Jan 8, 2024 · 3 comments · May be fixed by #1979
Closed
2 tasks done

Notifications Tag filter doesn't work #1977

evie-lau opened this issue Jan 8, 2024 · 3 comments · May be fixed by #1979
Labels
Status: Maybe One Day Type: Feature Request Issue is a feature request.

Comments

@evie-lau
Copy link

evie-lau commented Jan 8, 2024 •
edited

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

Notification connection with a tag filter is still providing notifications for Indexers without a matching tag.

Expected Behavior

Notification connection with a tag filter should only notify for Indexers with the matching tag, and should ignore events from Indexers without the matching tag.

Steps To Reproduce

  1. Create a new tag, apply it to one indexer.
  2. Setup a notification connection that uses the new tag.
  3. Wait for an indexer (without the tag) to fail a health check

Environment

- OS: Mint 21.3
- Prowlarr: Prowlarr 1.11.4.4173 and 1.12.0.4188
- Docker Install: Yes
- Using Reverse Proxy: Yes

What branch are you running?

Develop

Trace Logs?

Here's the trace logs from when the Health check failed for an indexer that was NOT tagged to provide notifications.

2024-01-08 16:44:26.9|Trace|Http|Req: 396 [GET] /api/v1/command (from 172.*.*.86 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0)
2024-01-08 16:44:26.9|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:26.9|Trace|CommandQueueManager|Getting all commands
2024-01-08 16:44:26.9|Trace|Http|Res: 396 [GET] /api/v1/command: 200.OK (7 ms)
2024-01-08 16:44:26.9|Debug|Api|[GET] /api/v1/command: 200.OK (7 ms)
2024-01-08 16:44:27.9|Trace|IndexerHttpClient|Res: HTTP/2.0 [GET] https://nyaa.land/?f=0&c=1_2&s=seeders&o=desc: 504.GatewayTimeout (15 bytes)
error code: 504 (60685 ms)
2024-01-08 16:44:27.9|Warn|Cardigann|HTTP Error - Res: HTTP/2.0 [GET] https://nyaa.land/?f=0&c=1_2&s=seeders&o=desc: 504.GatewayTimeout (15 bytes)
error code: 504
2024-01-08 16:44:28.0|Trace|EventAggregator|Publishing ProviderStatusChangedEvent<IIndexer>
2024-01-08 16:44:28.0|Trace|EventAggregator|ProviderStatusChangedEvent<IIndexer> -> IndexerStatusController
2024-01-08 16:44:28.0|Trace|EventAggregator|ProviderStatusChangedEvent<IIndexer> <- IndexerStatusController
2024-01-08 16:44:28.0|Warn|Cardigann|Unable to connect to Nyaa.si backup at [https://nyaa.land/?f=0&c=1_2&s=seeders&o=desc]. Indexer's server is unavailable. Try again later. HTTP request failed: [504:GatewayTimeout] [GET] at [https://nyaa.land/?f=0&c=1_2&s=seeders&o=desc]
2024-01-08 16:44:28.0|Trace|EventAggregator|Publishing IndexerQueryEvent
2024-01-08 16:44:28.0|Trace|EventAggregator|IndexerQueryEvent -> HistoryService
2024-01-08 16:44:28.0|Trace|EventAggregator|IndexerQueryEvent <- HistoryService
2024-01-08 16:44:28.0|Debug|ReleaseSearchService|Total of 0 reports were found for Term: [] for Season / Episode:[], Offset: 0, Limit: 100, Categories: [5000, 5070, 140679] from 1 indexer(s)
2024-01-08 16:44:28.0|Trace|Http|Res: 394 [GET] /8/api?t=tvsearch&cat=5000,5070,140679&extended=1&apikey=(removed)&offset=0&limit=100: 429.TooManyRequests (60765 ms)
2024-01-08 16:44:28.0|Trace|Http|Req: 397 [GET] /api/v1/indexerStatus (from 172.*.*.86 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0)
2024-01-08 16:44:28.0|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:28.0|Trace|Http|Res: 397 [GET] /api/v1/indexerStatus: 200.OK (4 ms)
2024-01-08 16:44:28.0|Debug|Api|[GET] /api/v1/indexerStatus: 200.OK (4 ms)
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health -> IndexerCheck
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health <- IndexerCheck
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health -> IndexerLongTermStatusCheck
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health <- IndexerLongTermStatusCheck
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health -> IndexerStatusCheck
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'uilanguage' defaultValue:'en'
2024-01-08 16:44:33.0|Trace|HealthCheckService|Check health <- IndexerStatusCheck
2024-01-08 16:44:33.0|Trace|EventAggregator|Publishing HealthCheckFailedEvent
2024-01-08 16:44:33.0|Trace|EventAggregator|HealthCheckFailedEvent -> NotificationService
2024-01-08 16:44:33.0|Trace|HttpClient|Req: [POST] https://discord.com/api/webhooks/xxxxxxxxxxxxxxxxxxx/xxxxxxxxxxxxxxxx
2024-01-08 16:44:33.0|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False'
2024-01-08 16:44:33.4|Trace|HttpClient|Res: HTTP/2.0 [POST] https://discord.com/api/webhooks/xxxxxxxxxxxxxxxxxxx/xxxxxxxxxxxxxxxx: 204.NoContent (0 bytes) (350 ms)
2024-01-08 16:44:33.4|Trace|EventAggregator|HealthCheckFailedEvent <- NotificationService
2024-01-08 16:44:33.4|Trace|EventAggregator|Publishing HealthCheckCompleteEvent
2024-01-08 16:44:33.4|Trace|EventAggregator|HealthCheckCompleteEvent -> HealthController
2024-01-08 16:44:33.4|Trace|EventAggregator|HealthCheckCompleteEvent <- HealthController
2024-01-08 16:44:33.4|Trace|EventAggregator|HealthCheckCompleteEvent ~> NotificationService
2024-01-08 16:44:33.4|Trace|EventAggregator|HealthCheckCompleteEvent <~ NotificationService
2024-01-08 16:44:33.4|Trace|Http|Req: 398 [GET] /api/v1/health (from 172.*.*.86 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0)
2024-01-08 16:44:33.4|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:33.4|Trace|Http|Res: 398 [GET] /api/v1/health: 200.OK (12 ms)
2024-01-08 16:44:33.4|Debug|Api|[GET] /api/v1/health: 200.OK (12 ms)
2024-01-08 16:44:56.4|Trace|Http|Req: 399 [GET] /6/api?t=music&cat=3000&extended=1&apikey=(removed)&offset=0&limit=100 (from 192.168.89.7 Lidarr/2.0.7.3849 (alpine 3.18.5))
2024-01-08 16:44:56.4|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:56.4|Trace|Http|Req: 401 [GET] /8/api?t=search&cat=3000&extended=1&apikey=(removed)&offset=0&limit=100 (from 192.168.89.7 Lidarr/2.0.7.3849 (alpine 3.18.5))
2024-01-08 16:44:56.4|Trace|Http|Req: 400 [GET] /2/api?t=music&cat=3000,3010,3040,3050,3030&extended=1&apikey=(removed)&offset=0&limit=100 (from 192.168.89.7 Lidarr/2.0.7.3849 (alpine 3.18.5))
2024-01-08 16:44:56.4|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:56.4|Debug|Prowlarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was successfully authenticated.
2024-01-08 16:44:56.4|Trace|Http|Res: 401 [GET] /8/api?t=search&cat=3000&extended=1&apikey=(removed)&offset=0&limit=100: 429.TooManyRequests (8 ms)
2024-01-08 16:44:56.4|Debug|IndexerFactory|Temporarily ignoring indexer Nyaa.si backup till 01/08/2024 16:45:28 due to recent failures.
2024-01-08 16:44:56.4|Info|ReleaseSearchService|Searching indexer(s): [1337x] for Term: [], Offset: 0, Limit: 100, Categories: [3000, 3010, 3040, 3050, 3030]
2024-01-08 16:44:56.4|Trace|Cardigann|Getting Music search
2024-01-08 16:44:56.4|Trace|ConfigService|Using default config value for 'logindexerresponse' defaultValue:'False'
2024-01-08 16:44:56.4|Trace|Cardigann|Populating config vars
2024-01-08 16:44:56.4|Debug|Cardigann|Adding request: https://1337x.to/cat/Movies/seeders/desc/1/
2024-01-08 16:44:56.4|Debug|Cardigann|Downloading Feed https://1337x.to/cat/Movies/seeders/desc/1/
2024-01-08 16:44:56.4|Trace|ConfigService|Using default config value for 'logindexerresponse' defaultValue:'False'
2024-01-08 16:44:56.4|Debug|IndexerFactory|Temporarily ignoring indexer Nyaa.si backup till 01/08/2024 16:45:28 due to recent failures.
2024-01-08 16:44:56.4|Info|ReleaseSearchService|Searching indexer(s): [TheRARBG] for Term: [], Offset: 0, Limit: 100, Categories: [3000]
2024-01-08 16:44:56.4|Debug|Http|Applying HTTP(S) Proxy Http to request https://1337x.to/cat/Movies/seeders/desc/1/
2024-01-08 16:44:56.4|Trace|Cardigann|Getting Music search

Trace Logs have been provided as applicable. Reports may be closed if the required logs are not provided.

  • I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.
@evie-lau evie-lau added Status: Needs Triage New Issue needing triage Type: Bug Issue is a bug labels Jan 8, 2024
@evie-lau
Copy link
Author

evie-lau commented Jan 8, 2024

I took a look at the NotificationService and saw there should be debug logs for the tag checking in the ShouldHandleIndexer function. But I didn't any of these messages in my full trace logs file.

@evie-lau
Copy link
Author

evie-lau commented Jan 8, 2024

Update: it seems the tags only apply to IndexerDownloadEvents?

Is it intended behavior for all Indexer health checks to send notifications, regardless of tag matching?

@mynameisbogdan
Copy link
Contributor

mynameisbogdan commented Jan 8, 2024 •
edited

That's correct, the tags association only works for grabs currently.

We have plans to add this in the future, but not at the moment.

@mynameisbogdan mynameisbogdan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
@mynameisbogdan mynameisbogdan added Type: Feature Request Issue is a feature request. Status: Maybe One Day and removed Type: Bug Issue is a bug Status: Needs Triage New Issue needing triage labels Jan 8, 2024
@mynameisbogdan mynameisbogdan mentioned this issue Jan 9, 2024
Draft
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Maybe One Day Type: Feature Request Issue is a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Handle health checks with matching indexer tags Prowlarr/Prowlarr
2 participants
@evie-lau @mynameisbogdan