Global state mutation in loader functions breaks multi-versioning in one process

[extremeheat]

https://github.com/PrismarineJS/mineflayer/blob/7bb9ea09f2be4d9dc741beedc67625efe243438d/lib/bossbar.js

For example,

let ChatMessage
const colors = ['pink', 'blue', 'red', 'green', 'yellow', 'purple', 'white']
const divisions = [0, 6, 10, 12, 20]

module.exports = loader

function loader (registry) {
  ChatMessage = require('prismarine-chat')(registry)
  return BossBar
}

class BossBar {
  constructor (uuid, title, health, dividers, color, flags) {
    this._entityUUID = uuid
    this._title = new ChatMessage(JSON.parse(title))
    this._health = health

will result in all BossBar classes having their ChatMessage being updated to whatever the last caller to loader() specified. In this case it's a special case because the constructor is only called once, but in other places it will cause unexpected behaviours, like here https://github.com/PrismarineJS/mineflayer/blob/b9491ae508dc52e4538dd66eb6f47a639facde20/lib/team.js

[rom1504]

Indeed! I guess we should follow the same loader pattern as in prismarine-* classes

[rom1504]

Is this fixed now @extremeheat ?

[extremeheat]

Seems like prismarine-recipe still has issue https://github.com/PrismarineJS/prismarine-recipe/blob/master/lib/recipe.js

Maybe some others, I just did a quick search for loader functions in the org