Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support for nullability annotations #2958

Open
bdovaz opened this issue Sep 15, 2023 · 3 comments
Open

[Enhancement] Support for nullability annotations #2958

bdovaz opened this issue Sep 15, 2023 · 3 comments

Comments

@bdovaz
Copy link
Contributor

bdovaz commented Sep 15, 2023

Microsoft and the community is continuously working on making the migration where possible.

Currently in WPF it's also proposed: dotnet/wpf#7563

Since you are working on a new version, it is a good time to support it.

If you need help, I have no problem creating a PR for this.

@dansiegel
Copy link
Member

You'll notice that this is starting to work it's way in one API at a time. Unfortunately it's not going to be the quickest or easiest thing as broadly enabling nullability will break too many things and require too many changes. We are happy to take small focused PRs towards this end though.

https://github.com/PrismLibrary/Prism/blob/91beae021cfeefef4bc68bbcc89da29500d727b3/src/Prism.Core/Commands/AsyncDelegateCommand.cs#L8C1-L8C17

@bdovaz
Copy link
Contributor Author

bdovaz commented Sep 15, 2023

First attempt in #2959

@dansiegel
Copy link
Member

Please hold off on any more PRs for this until after we do the Prism 9 preview. But absolutely appreciate the help to start getting these updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants