Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the DirectoryModuleCatalog lookup DLL be changed to all subdirectories? #2930

Open
BoyFaceGirl opened this issue Aug 16, 2023 · 1 comment

Comments

@BoyFaceGirl
Copy link

BoyFaceGirl commented Aug 16, 2023

Summary

https://github.com/PrismLibrary/Prism/blob/bf0966af97a7dd16141ed3b3c3cfc784ff5e0cb7/src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.netcore.cs#L102C33-L102C51

The module DLL may exist in some subdirectories, and the current search method cannot find the DLL

e.g.

var fileInfos = directory.GetFiles("*.dll",SearchOption.AllDirectories)

@brianlagunas
Copy link
Member

This would not be implemented as you have here, but maybe via an exposed property to control the options. Would you like to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants