New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: PolyMC does not properly respect some org.lwjgl3.json's after 09e85e948cdb361c306a1cccbc3557a464366a21 #2392
Comments
Try this on the latest prism: This is the same file mentioned but with a little change: the commit you mentioned added support for multiple architectures so instead of having just "linux" we check for "linux-ppc64le" so the only change was where you find |
I would not call this a regression per-se. Previously, the launcher did not differentiate between natives across different CPU architectures. As multi-arch natives were previously unsupported (apart from what Mojang shipped), we decided to change |
Alright, that instance worked with git master prism, thanks! So everything works as intended then? People should just have to adapt their instances? |
Well, wouldn't it make the most sense if |
yes
I feel like that would be even more confusing than the current situation. Ideally os, cpu architecture and maybe even libc impl would be clearly distinct |
Operating System
Linux, PPC64le architecture, using custom natives
Version of Prison
Tested up to latest git master, still seems present
Version of Qt
5.15.13
6.7.0
I believe this old commit (where the regression is) only supported Qt5
Description of bug
The instances listed here only work at or before commit
09e85e948cdb361c306a1cccbc3557a464366a21
(introduced during poly). For example-- this instance here. Before this regression, it downloaded the natives specified inorg.lwjgl3.json
, currently, it doesn't and just errors out. (will show log of what happens currently, but will have to wait to rebuild yet again).Note that my git bisect knocked down the troublesome commit to either
09e85e948cdb361c306a1cccbc3557a464366a21
or the one immediately after. I could not test the one after due to an unrelated build failure with the code (if you want me to test this commit, I can try again and patch the code to fix each build failure one by one).Also note that I am unable to test with a non-offline account. could be related(?)
Steps to reproduce
I think that it should still be testable on a non ppc machine (testing whether it respects the json files), but if any Prison dev wishes to test on real ppc hardware they can reply here or on discord with an ssh pubkey. rrogalski#0 on discord
This issue is unique
before regression. it works!
after regression (poly) + after2.txt , git master build of poly. you can see it is no longer using the natives
prism + prism.txt. This is the git master build of prism. Still is affected by the regression
The text was updated successfully, but these errors were encountered: