Add neoforge support for technic packs and atlauncher packs #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
enhancement
|
The technic modpack can be tested with: #2380 (comment) |
Trial97
removed
the
needs-testing
|
Huh, I wonder what's going on here and why the nf version is only mentioned in arguments. |
TheKodeToad
approved these changes
May 9, 2024
DioEgizio
approved these changes
May 11, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2380
Added neoforge support for both technic and atlauncher.
Because there may not be any atlauncher modpack that has yet neoforge that part can't be tested, it should be ok to have the check there for now.
Regarding the technic pack I'm waiting for to get a pack from the user that opened the mentioned issue.
But it should work based on how technic packs are made: https://support.technicpack.net/hc/en-us/articles/17049267195021-How-to-Create-a-Client-Modpack#Installing-a-mod-loader