Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism Launcher itself crashes when launching All of Fabric 7, relating to "ModUtils::ReadMCModTOML" #2241

Open
1 task done
unilock opened this issue Mar 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@unilock
Copy link

unilock commented Mar 25, 2024

Operating System

macOS

Version of Prism Launcher

"bleeding edge" via nix flake (currently 1627f3c)

Version of Qt

Qt 6.6.2

Description of bug

Upon launching the modpack "All of Fabric 7", version 2.0.0, Prism Launcher crashes. (Minecraft still launches fine!)

Crash report generated by macOS: https://gist.github.com/unilock/5c0a5dfd8f98d723c78d0e3f05c82107

Steps to reproduce

  1. Install Prism Launcher
  2. Install All of Fabric 7 (i.e. from CurseForge or this link)
  3. Launch the modpack
  4. Crash

Suspected cause

It seems to be related to ModUtils::ReadMCModTOML, according to the crash report.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@unilock unilock added the bug Something isn't working label Mar 25, 2024
@Trial97
Copy link
Member

Trial97 commented Mar 25, 2024

Sadly I can't reproduce this.
But the strange part is that it reports a throw here: https://github.com/PrismLauncher/PrismLauncher/blob/develop/launcher/minecraft/mod/tasks/LocalModParseTask.cpp#L104-L116

So I'm confused: the compiler reports wrong that it supports throws and when a throw happens the app crashes.
Should we add cmakae option to toggle TOML_EXCEPTIONS on and off?

@unilock
Copy link
Author

unilock commented Mar 27, 2024

Sadly I can't reproduce this.

I would not be surprised if it's somehow an Apple Silicon-specific and/or macOS-specific problem. (I use a MacBook Air M2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants