Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod dependencies persist after deselect #2169

Open
1 task done
TheKodeToad opened this issue Feb 27, 2024 · 0 comments · May be fixed by #2173
Open
1 task done

Mod dependencies persist after deselect #2169

TheKodeToad opened this issue Feb 27, 2024 · 0 comments · May be fixed by #2173
Labels
bug Something isn't working

Comments

@TheKodeToad
Copy link
Member

Operating System

No response

Version of Prism Launcher

Version 8.0

Version of Qt

n/a

Description of bug

Pressing Review and confirm causes all mod dependencies to be added to the to download dialog. The UI does not update until searching.

The issue with this is that when you deselect or change the mod version, the dependencies are still queued for install.

I would suggest adding the tasks in a less persistent way where only the review dialog is aware of them

Steps to reproduce

  • Select LambDynamicLights
  • Press Review and confirm
  • Press Back
  • Deselect LambDynamicLights
  • Press Review and confirm
  • Only Fabric API will be installed

Suspected cause

No response

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@TheKodeToad TheKodeToad added the bug Something isn't working label Feb 27, 2024
@Trial97 Trial97 linked a pull request Feb 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependencies if review mods is rejected Trial97/PrismLauncher
1 participant
@TheKodeToad