Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update checker running when it shouldn't #2013

Open
1 task done
NotADinosaur opened this issue Jan 5, 2024 · 5 comments · May be fixed by #2054
Open
1 task done

update checker running when it shouldn't #2013

NotADinosaur opened this issue Jan 5, 2024 · 5 comments · May be fixed by #2054
Labels
bug Something isn't working

Comments

@NotADinosaur
Copy link

NotADinosaur commented Jan 5, 2024 •
edited

Operating System

Windows

Version of Prism Launcher

8.0

Version of Qt

6.6.0

Description of bug

I recently switched from multimc after I accidentally uninstalled it (yep, I'm dumb lol) because I'd heard prism was better, and rather than running the update check on launch it seems to run at random times. Sometimes it does it when it's supposed to, but other times it does it hours later when I'm doing something else, forcing the "no updates found" window to be the focus, interrupting whatever other program I'm running (e.g playing a different game). Twice now it has even done this after I closed prismlauncher (using the X button in the titlebar) because it continues running as a background task only visible in task manager for some reason.

Steps to reproduce

It doesn't happen consistently so I'm not sure what to put here. Just use the launcher I guess? Never happened with multimc.

Suspected cause

No response

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@NotADinosaur NotADinosaur added the bug Something isn't working label Jan 5, 2024
@Trial97
Copy link
Member

Trial97 commented Jan 5, 2024

What updater do you mean: mod updater or prism updater?
When closing prism make sure you do not have any instances running(if not prism will run in the background).
Can you provide some logs?

@NotADinosaur
Copy link
Author

I'm talking about the prism updater. I might've had minecraft running, that would make sense I suppose, however it still should not randomly be running the updater after it has been in the background for a while. I don't see how minecraft logs would be relevant to this issue.

@Trial97
Copy link
Member

Trial97 commented Jan 7, 2024

I meant prism logs. They are located inside the prism data root directory inside the logs folder. There should be multiple files that are numbered from 0 to 4(0 means is the most recent).
So once it reproduces please upload all the files that have a 0(there should be multiple files), but make sure you check for personal data(upload it to a pastebin service please).
Also please check, using task manager, if prism is still running after you close it.

@Trial97
Copy link
Member

Trial97 commented Jan 7, 2024

Also there is a setting for that that you can toggle off: Settings>Launcher>Check for updates automatically

@phit
Copy link
Contributor

phit commented Jan 13, 2024

turning this on in multimc only does an update check when the launcher is started, not on a timer

PrismLauncher/launcher/updater/PrismExternalUpdater.cpp

Line 70 in f931890

if (!last_check.isNull() && last_check.isValid()) {

supposedly this should be once a day but I also have noticed this coming up after having the launcher open for a couple of hours forcing focus on the update window

@Trial97 Trial97 linked a pull request Jan 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made updater interval configurable Trial97/PrismLauncher
3 participants
@phit @Trial97 @NotADinosaur