Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading of required libraries & assets included in instance playtime #1051

Open
1 task done
kkiris opened this issue May 1, 2023 · 0 comments · May be fixed by #1886
Open
1 task done

Downloading of required libraries & assets included in instance playtime #1051

kkiris opened this issue May 1, 2023 · 0 comments · May be fixed by #1886
Labels
bug Something isn't working

Comments

@kkiris
Copy link

kkiris commented May 1, 2023

Operating System

Windows

Version of Prism Launcher

Prism Launcher 6.3

Version of Qt

Qt 6.4.2

Description of bug

When launching a Minecraft version for the first time, the assets need to be downloaded from Mojang. The time spent downloading the assets is included in the playtime for the instance (displayed at the bottom of the launcher).
When required libraries are downloading on first launch, the time downloading the libraries is also included in the instance's playtime.

If any of these files fail to download, and the instance does not successfully launch, the instance will still have playtime logged.

I would expect that if the game does not launch, time should not be logged for the instance.

Steps to reproduce

  • Create a new instance for a version of Minecraft you've not yet played through Prism Launcher.
  • Press the Abort button while the launcher is downloading assets from Mojang.
  • Observe that playtime has been logged for the instance in the launcher.

Suspected cause

No response

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@kkiris kkiris added the bug Something isn't working label May 1, 2023
This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant