You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Revising the server logs on a prod site I came to this:
[Mon Apr 29 22:31:38.320595 2024] [proxy_fcgi:error] [pid 4026259:tid 140238351742720] [remote 00.00.00.00:60515] AH01071: Got error '
PHP message: PHP Notice: Undefined offset: 3 in /var/www/public_html/modules/dashactivity/dashactivity.php on line 303
PHP message: PHP Notice: Undefined offset: 3 in /var/www/public_html/modules/dashactivity/dashactivity.php on line 291
Then revising the module I saw few issues & incongruences:
Go to dashboard and select Today stats:
First, the module will call twice the same function, getReferer(), without caching, this is not an issue on this context since this module always limit the result to 3, but:
Limiting the result to 3, we will only see always the sum of 3, as per image:
After removing the limit I get all results, there are many but with those is Ok to explain the issue:
The notices are caused because the code limits it to three, and there only three different colors, but the following code is adding a fourth referrer manually, the Direct Link.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi
Revising the server logs on a prod site I came to this:
Then revising the module I saw few issues & incongruences:
Go to dashboard and select Today stats:
First, the module will call twice the same function, getReferer(), without caching, this is not an issue on this context since this module always limit the result to 3, but:
Limiting the result to 3, we will only see always the sum of 3, as per image:
After removing the limit I get all results, there are many but with those is Ok to explain the issue:
The notices are caused because the code limits it to three, and there only three different colors, but the following code is adding a fourth referrer manually, the Direct Link.
https://github.com/PrestaShop/dashactivity/blob/b1889de793f9d936f97f2f6f5af462296946e211/dashactivity.php#L309-L336
Before I try to work on this, is PS going to keep this module and traffic stats?
Before this Q&A I just searched everywhere and didn't find anything related.
Thanks
Beta Was this translation helpful? Give feedback.
All reactions