Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Trirank documentation X&Y #618

Closed
linan1109 opened this issue May 14, 2024 · 2 comments · Fixed by #619
Closed

[BUG] Trirank documentation X&Y #618

linan1109 opened this issue May 14, 2024 · 2 comments · Fixed by #619
Assignees
@lthoang

Comments

@linan1109
Copy link

linan1109 commented May 14, 2024 •
edited

For model.Triank, the document says X is for user-aspect and Y is for item-aspect.

But in the code, it should be the other way round, i.e. X for item-aspect and Y for user-aspect.

image

image
@tqtg
Copy link
Member

tqtg commented May 16, 2024

@lthoang is it something to be corrected?

@lthoang
Copy link
Member

lthoang commented May 16, 2024

Based on the original paper, the code is correct. I made a mistake in the model's documentation.
image

So we have to update the documentation accordingly.

@linan1109 Thank you for pointing out this error.

@lthoang lthoang mentioned this issue May 16, 2024
Merged
5 tasks
@lthoang lthoang linked a pull request May 16, 2024 that will close this issue
Update TriRank documentation #619
Merged
5 tasks
@tqtg tqtg closed this as completed in #619 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lthoang lthoang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update TriRank documentation PreferredAI/cornac
3 participants
@lthoang @tqtg @linan1109